Skip to content

Fix pipeline transcript lookup#1797

Merged
chubes4 merged 1 commit intomainfrom
fix/pipeline-terminal-tools-transcripts
May 5, 2026
Merged

Fix pipeline transcript lookup#1797
chubes4 merged 1 commit intomainfrom
fix/pipeline-terminal-tools-transcripts

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented May 5, 2026 •
edited
Loading

Summary

  • Store pipeline transcript session IDs back onto the originating job so jobs transcript <id> can resolve persisted transcripts.
  • Let jobs transcript <id> recover older transcript rows by metadata.job_id when engine_data.transcript_session_id is missing.
  • Make duplicate tool-call guidance generic instead of assuming every pipeline has a publish handler.

Testing

  • php -l inc/Core/Steps/AI/AIStep.php && php -l inc/Engine/AI/DataMachineHandlerCompletionPolicy.php && php -l inc/Engine/AI/conversation-loop.php && php -l inc/Engine/AI/DataMachinePipelineTranscriptPersister.php && php -l inc/Cli/Commands/JobsCommand.php && php -l inc/Engine/AI/ConversationManager.php
  • php tests/agent-conversation-runtime-policy-smoke.php && php tests/duplicate-tool-call-mode-aware-smoke.php && php tests/pipeline-transcript-session-link-smoke.php
  • ./vendor/bin/phpcs inc/Cli/Commands/JobsCommand.php inc/Core/Steps/AI/AIStep.php inc/Engine/AI/ConversationManager.php inc/Engine/AI/DataMachineHandlerCompletionPolicy.php inc/Engine/AI/DataMachinePipelineTranscriptPersister.php inc/Engine/AI/conversation-loop.php tests/agent-conversation-runtime-policy-smoke.php tests/duplicate-tool-call-mode-aware-smoke.php tests/pipeline-transcript-session-link-smoke.php

Notes

  • The GitHub issue creation workflow should use the existing AI -> publish pipeline shape. This PR intentionally does not add AI-only terminal tool support.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (gpt-5.5)
  • Used for: Diagnosed transcript lookup behavior, drafted the focused runtime fix, and added smoke coverage. Chris reviewed the architecture direction and requested the terminal-tool path be removed.

@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented May 5, 2026 •
edited
Loading

Homeboy Results — data-machine

Lint

✅ lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine --changed-since c2058e2

Test

❌ test — failed

  • 1 failed out of 846 total
  • 3 skipped
  • DataMachine\Tests\Unit\Abilities\ImageGenerationPromptRefinementTest::test_refine_prompt_includes_post_context_when_provided

ℹ️ To run specific tests: homeboy test data-machine -- --filter=TestName
ℹ️ Auto-fix lint issues: homeboy refactor data-machine --from lint --write
ℹ️ Collect coverage: homeboy test data-machine --coverage
ℹ️ Save test baseline: homeboy test data-machine --baseline
ℹ️ Analyze failures: homeboy test data-machine --analyze
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine --changed-since c2058e2

Audit

✅ audit — passed

  • test_coverage — 276 finding(s)
  • dead_code — 133 finding(s)
  • intra-method-duplication — 59 finding(s)
  • requested_detectors — 28 finding(s)
  • repeated_literal_shape — 13 finding(s)
  • parallel-implementation — 12 finding(s)
  • dead_guard — 10 finding(s)
  • field_patterns — 5 finding(s)
  • Abilities — 4 finding(s)
  • Flow — 4 finding(s)
  • Total: 557 finding(s)

Deep dive: homeboy audit data-machine --changed-since c2058e2

Tooling versions
  • Homeboy CLI: homeboy 0.157.1+4af3cd9f
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: a9f3e87
  • Action: Extra-Chill/homeboy-action@v2

@chubes4 chubes4 force-pushed the fix/pipeline-terminal-tools-transcripts branch from 11c5130 to d2a5551 Compare May 5, 2026 17:55
@chubes4 chubes4 changed the title Fix pipeline transcript and terminal tool handling Fix pipeline transcript lookup May 5, 2026
@chubes4 chubes4 merged commit e73da7b into main May 5, 2026
3 checks passed
@chubes4 chubes4 deleted the fix/pipeline-terminal-tools-transcripts branch May 5, 2026 17:56
@chubes4 chubes4 mentioned this pull request May 6, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chubes4